On Wed, 21 May 2008 18:29:07 -0700 David Brownell <[EMAIL PROTECTED]> wrote:
> Somehow the spidev code forgot to include a critical mechanism: > when the underlying device is removed (e.g. spi_master rmmod), > open file descriptors must be prevented from issuing new I/O > requests to that device. On penalty of the oopsing reported > by Sebastian Siewior <[EMAIL PROTECTED]> ... > > This is a partial fix, adding handshaking between the lower > level (SPI messaging) and the file operations using the spi_dev. > There's still a refcounting issue to be addressed (separately) > with respect to the spidev_data itself. > For 2.6.26, I assume? > +static inline int > +spidev_sync_write(struct spidev_data *spidev, size_t len) > +static inline int > +spidev_sync_read(struct spidev_data *spidev, size_t len) These strictly should return a ssize_t. The inlining is wrong+pointless, but I appear to be losing that struggle. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
