On Monday 12 October 2009, Mike Frysinger wrote: > i was browsing the change history of spidev when i noticed the change: > aaacf4bb51b243875b203e6ff73b5047636b4efa spi: avoid spidev crash when > device is removed > > which seems to be due to this change: > 3d81252ddb10f63ae4db713d9b32faabe641b850 device create: spi: convert > device_create to device_create_drvdata > > getting an incomplete revert with this change: > a9b12619f7b6f19c871437ec24a088787a04b1de device create: misc: convert > device_create_drvdata to device_create
More accurately: not a revert, but a name change. > my point being is that the original code was doing the > spi_set_drvdata() while holding the device_list_lock mutex while the > new one is not. shouldnt the code be changed back to the state > previous to 3d81252d ? Yes, that particular assignment should be mutex-protected. The original patch shouldn't really have removed it; the change to the device_create() signature was addressing a slightly different race. - Dave > -mike > > ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
