Re: [spi-devel-general] [PATCH v4] serial: spi: add spi-uart driver for Maxim 3110

[Feng Tang]

On Fri, 26 Feb 2010 17:59:38 +0800
Masakazu Mokuno <mok...@sm.sony.co.jp> wrote:

> Hi,
> 
> > +   u8 *pbuf, valid_str[M3110_RX_FIFO_DEPTH];
> > +   int i, j;
> > +
> > +   memset(obuf, 0, sizeof(obuf));
> > +   memset(obuf, 0, sizeof(ibuf));
> 
> memset(ibuf, 0, sizeof(ibuf))?

thanks for the catch, here is a follow on patch


diff --git a/drivers/serial/max3110.c b/drivers/serial/max3110.c
index 3283ba6..3dd2082 100644
--- a/drivers/serial/max3110.c
+++ b/drivers/serial/max3110.c
@@ -142,7 +142,7 @@ static int max3110_read_multi(struct uart_max3110 *max, u8 
*buf)
        int i, j;
 
        memset(obuf, 0, sizeof(obuf));
-       memset(obuf, 0, sizeof(ibuf));
+       memset(ibuf, 0, sizeof(ibuf));
 
        if (max3110_write_then_read(max, obuf, ibuf,
                                M3110_RX_FIFO_DEPTH * 2, 1))

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general