On Sun, Apr 25, 2010 at 02:55:08PM -0500, H Hartley Sweeten wrote:
> On Saturday, April 24, 2010 11:15 AM, Martin Guy wrote:
> > static irqreturn_t ep93xx_spi_interrupt(int irq, void *dev_id)
> > {
> > ...
> > if (!(irq_status & (SSPIIR_RORIS | SSPIIR_TIS | SSPIIR_RIS)))
> > return IRQ_NONE; /* not for us */
> >
> > - /* clear the interrupt */
> > - ep93xx_spi_write_u8(espi, SSPICR, 0);
> >
> > /*
> > * If we got ROR (receive overrun) interrupt we know that something
> > is
> > * wrong. Just abort the message.
> > */
> > if (unlikely(irq_status & SSPIIR_RORIS)) {
> > + /* clear the overrun interrupt */
> > + ep93xx_spi_write_u8(espi, SSPICR, 0);
> > dev_warn(&espi->pdev->dev,
> > "receive overrun, aborting the message\n");
> > espi->current_msg->status = -EIO;
> > } else {
>
> With this patch the interrupts only get cleared if it's a ROR interrupt.
>
> Do the RIS/TIS interrupts get cleared by the upper layers? If so, do we
> really need to clear the ROR interrupt here?
I believe it is not necessary but doesn't hurt either so I would keep it.
Regards,
MW
------------------------------------------------------------------------------
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
