Hi,

I was having trouble to run 'spidev_test' on Phytec LPC3250 board when I
tried to change the SPI mode.

[r...@gsncommsmodule debug]# ./spidev_test -O
can't set spi mode: Invalid argument
Aborted

'dmesg' shows:
......
spidev spi1.0: setup: unsupported mode bits 2
......


According to source code: driver/spi/spi.c
............................
    bad_bits = spi->mode & ~spi->master->mode_bits;
    if (bad_bits) {
        dev_dbg(&spi->dev, "setup: unsupported mode bits %x\n",
            bad_bits);
        return -EINVAL;
    }
..............................


Therefore, I did following change on amba-pl022.c, which is used as SPI
master controller driver
-------------------------------------------------------------------

pl022_probe(struct amba_device *adev, struct amba_id *id)
{
       ...................................

    /* Allocate master with space for data */
    master = spi_alloc_master(dev, sizeof(struct pl022));
    if (master == NULL) {
        dev_err(&adev->dev, "probe - cannot alloc SPI master\n");
        status = -ENOMEM;
        goto err_no_master;

    }

        /* Quentin Added 2010-AUG-19 */
        master->mode_bits=MODEBITS;
    .........................

}

Now I can successfully set 'SPI mode' to mode 3.

[r...@gsncommsmodule debug]# ./spidev_test -OH
spi mode: 3
bits per word: 8
max speed: 500000 Hz (500 KHz)
00 00 00 00 00 00
00 00 00 00 00 00
00 00 00 00 00 00
00 00 00 00 00 00
00 00 00 00 00 00
00 00 00 00 00 00
00 00


Hope this patch can be added to amba-pl022.c in the next Linux kernel
release.


Regards,

*Quentin YANG***

*Firmware Engineer***

*Tel: +61-2-88787724***

*CHK GridSense Pty Ltd*

Unit 3, 20-36 Nancarrow Ave

Meadowbank, NSW, 2114, Australia

Web Site:  http://www.gridsense.com
------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to