>> /* Quentin Added 2010-AUG-19 */ >> master->mode_bits=MODEBITS; >> ......................... >>
> > It looks like some additional setup is needed in pl022_setup() to setup these > modes in hardware. Setting the mode_bits mask alone only tricks the > application into thinking SPI mode 3 has been set, but nothing will change > in hardware on the next setup if the passed mode isn't handled there too. > > Some of the transfer setup config - data width, clock rate, SPI mode, > etc - are actually setup on a per transfer basis and may vary based on how > spidev (and in this case the spidev_test app) configures it. For these > specific > setup items, we probably shouldn't use the static chip_info version of the > transfer config - maybe we can use the config passed in 'struct spi_transfer' > instead. > > This would also reduce the size of the struct pl022_config_chip controller > data structure since some of those fields would now be handled in the > spi_transfer structure. > > I guess this change is bigger than anticipated :( > Hi Linus, I use this driver quite a bit here - Is it ok if try to get the setup based on spi->mode instead of the controller_data info? thanks, Kevin ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
