On Tue, Sep 7, 2010 at 7:29 PM, Mark Brown <[email protected]> wrote: > Allow the use of the S3C64xx SPI controller with things like PMICs by > moving the init up to subsys_initcall(). > > Signed-off-by: Mark Brown <[email protected]> > --- > > Incidentally I don't seem to see anything in the current SPI tree for > -next - should the tree being used be updated or something? > > drivers/spi/spi_s3c64xx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c > index f72e1c0..6e48ea9 100644 > --- a/drivers/spi/spi_s3c64xx.c > +++ b/drivers/spi/spi_s3c64xx.c > @@ -1181,7 +1181,7 @@ static int __init s3c64xx_spi_init(void) > { > return platform_driver_probe(&s3c64xx_spi_driver, s3c64xx_spi_probe); > } > -module_init(s3c64xx_spi_init); > +subsys_initcall(s3c64xx_spi_init);
Couldn't any user ever need to load it as a module? If no, we might as well drop the s3c64xx_spi_exit and s3c64xx_spi_remove as well and save space. Rather going a step further, shouldn't then all spi drivers be that way? Two steps further, why not every 'bus-driver' ? ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
