On 10 July 2012 20:08, Mark Brown <[email protected]> wrote: > On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since all the platforms currently use gpio >> as the slave select line, this callback can be removed from the >> controller data and replaced with call to gpio_set_value in the driver. > > This is currently buggy, BTW, as the driver never requests the GPIO.
In non-dt case, the platform code supplying the gpio number (slave select line) is responsible for requesting the gpio during the machine_init call. So the gpio request is not called in the driver for that gpio. In dt case, the 6th patch adds dt support and that patch includes a gpio request call. Hence, this looks okay to me. Please suggest if you still feel that there are changes required. Thanks for reviewing the patches. Regards, Thomas. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
