On 10 July 2012 22:27, Mark Brown <[email protected]> wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So the gpio request is not called in the driver for >> that gpio. In dt case, the 6th patch adds dt support and that patch >> includes a gpio request call. Hence, this looks okay to me. Please >> suggest if you still feel that there are changes required. > > That's not really particularly sensible given that the changes remove > the option to use anything except GPIOs, the GPIO request should be done > unconditionally in the driver now.
Yes, that is right. I will add the gpio request in the driver and resubmit the patch. Thanks. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
