On Thu, 2012-12-06 at 14:19 +0000, Alan Cox wrote: > > > +late_initcall(intel_mid_ssp_spi_init); > > > > Why late_initcall()? module_init() should be sufficient. Or better yet > > replace the init and exit functions with module_pci_driver() > > Thats a legacy of the old SPI code not handling bus and device > registration in random orders. So it's no longer needed I believe. > > Alan
We use the late_initcall because we want init the spi driver after finished the dma driver with fs_initcall. Now we can not test the module_pci_driver replace the late_initcall because our kernel version is not brach 3.7. So maybe we can use old the late_initcall and update this code in the further, Do you agree? ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
