This is really great! I was trying to add it the other day but totally failed. It was very needed cause it makes the widget so much easier to use.

Unfortunately I can't help you with the signal/event review but from the little I know they seem fine. I just have one question: why was not it possible to add Enter as a keyboard shortcut to the widget here?

http://code.google.com/p/spyderlib/source/browse/spyderlib/widgets/findreplace.py?spec=svn9caff1b29c1499d11c90451442feec65be9e1795&r=9caff1b29c1499d11c90451442feec65be9e1795#143

(I say add it, because F3 has to continue working as usual). I mean, ¿why Enter has to be registered and processed as a keyboard event? I'm just asking because it seems a bit more complicated than adding a shortcut.

Anyway, great work on your side.

Cheers,
Carlos

El 04/05/12 02:54, anatoly techtonik escribió:
Hi,

I've fixed a long annoyance in Spyder - implemented "find next" on Enter. This is my first experience with Qt signal/event processing, so I'll appreciate if somebody could review this change and tell if it could be done better. http://code.google.com/p/spyderlib/source/detail?r=9caff1b29c1499d11c90451442feec65be9e1795 <http://code.google.com/p/spyderlib/source/detail?r=9caff1b29c1499d11c90451442feec65be9e1795&url_prefix=p>

In particular, I am interested if it is possible to pass parameters to signal handler.

Thanks for the feedback.
--
You received this message because you are subscribed to the Google Groups "spyder" group. To view this discussion on the web visit https://groups.google.com/d/msg/spyderlib/-/-ToQ_i5iSjcJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/spyderlib?hl=en.

--
You received this message because you are subscribed to the Google Groups 
"spyder" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/spyderlib?hl=en.

Reply via email to