On Fri, May 4, 2012 at 1:54 AM, anatoly techtonik <[email protected]>wrote:
> Hi, > > I've fixed a long annoyance in Spyder - implemented "find next" on Enter. > This is my first experience with Qt signal/event processing, so I'll > appreciate if somebody could review this change and tell if it could be > done better. > > http://code.google.com/p/spyderlib/source/detail?r=9caff1b29c1499d11c90451442feec65be9e1795<http://code.google.com/p/spyderlib/source/detail?r=9caff1b29c1499d11c90451442feec65be9e1795&url_prefix=p> > > In particular, I am interested if it is possible to pass parameters to > signal handler. > > Thanks for the feedback. > Looks great. You essentially did the same thing that Pierre had done in PatternComboBox, which is override keyPressEvent, so if there are complaints now there should have been complaints earlier :). It's the right way to go to accomplish what you intended to do as far as I know. I had just one question, which I attached to a code review here: http://code.google.com/p/spyderlib/source/detail?r=9caff1b29c1499d11c90451442feec65be9e1795&url_prefix=p -- You received this message because you are subscribed to the Google Groups "spyder" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/spyderlib?hl=en.
