On Sun, Oct 23, 2022, at 5:04 AM, Lele Gaifax wrote: > Lele Gaifax <[email protected]> writes: > > > I will propose a PR soon. > > An ethical concern: given that the proposed methods are so simple, is it > legal/acceptable to verbatim copy them, and their tests, from the > psycopg (LGPL) and asyncpg (Apache license)?
I would say that it's not! I wouldn't really look at the method bodies here and I wouldn't copy them and for tests we have our own testing formats and styles that wouldn't match those other libraries anyway. in my view, these are very trivial methods with trivial tests, just comparing upper/lower bounds to some value. It's not like we're copying a network protocol implementation or something. > > ciao, lele. > -- > nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri > real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. > [email protected] | -- Fortunato Depero, 1929. > > -- > SQLAlchemy - > The Python SQL Toolkit and Object Relational Mapper > > http://www.sqlalchemy.org/ > > To post example code, please provide an MCVE: Minimal, Complete, and > Verifiable Example. See http://stackoverflow.com/help/mcve for a full > description. > --- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:sqlalchemy%[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sqlalchemy/878rl6ap2z.fsf%40metapensiero.it. > -- SQLAlchemy - The Python SQL Toolkit and Object Relational Mapper http://www.sqlalchemy.org/ To post example code, please provide an MCVE: Minimal, Complete, and Verifiable Example. See http://stackoverflow.com/help/mcve for a full description. --- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sqlalchemy/34423625-680a-4c5b-8f57-7f982d87f88d%40app.fastmail.com.
