"Mike Bayer" <[email protected]> writes:

> these look super great!

Thanks! I will then open an issue and a related PR shortly.

> We can make the text("") statements into something nicer in a second
> pass, is that the part you didn't like ?

Not exactly: I spent some time trying to avoid the "redundancy" in the
tests parametrization, ie

    @testing.combinations(
        (Range(empty=True), 'empty'),
        (Range(None, None, bounds='()'), '(,)'),
        (Range(None, 4, bounds='(]'), '(,4]'),
        ...

ideally simplifying it to

    @testing.combinations(
        Range(empty=True),
        Range(None, None, bounds='()'),
        Range(None, 4, bounds='(]'),
        ...

and then being able to "compute" the SQL query from the given Range
instance alone, but I couldn't figure out how to obtain the
"compilation" of just a single value from the connection.dialect.

But hey, I do not expected those arguments will be changing often... :-)

ciao, lele
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
[email protected]  |                 -- Fortunato Depero, 1929.

-- 
SQLAlchemy - 
The Python SQL Toolkit and Object Relational Mapper

http://www.sqlalchemy.org/

To post example code, please provide an MCVE: Minimal, Complete, and Verifiable 
Example.  See  http://stackoverflow.com/help/mcve for a full description.
--- 
You received this message because you are subscribed to the Google Groups 
"sqlalchemy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sqlalchemy/874jvtukxz.fsf%40metapensiero.it.

Reply via email to