Sorry Daniel, my email filter got messed up and I missed this one.  

I've made the change, although I'm a bit concerned that the greedy regex
will eat too much.

Ben

On Sun, 2008-04-27 at 21:07 +0200, Daniel Böhringer wrote:
> line 886
> 
> 
> default_val  : DEFAULT /(\d+|'[^']*'|\w+\(.*?\))|\w+/
> 
> 
> should read
> 
> 
> default_val  : DEFAULT /(\d+|'[^']*'|\w+\(.*\))|\w+/
> 
> 
> otherwise,
> eg.
> "ID" integer DEFAULT
> nextval(('"AlleStudien_ID_seq"'::text)::regclass),
> 
> 
> will not qualify a correct default value. the brackets with
>  ::regclass appendix are dumped from postgres 8.2.6 and various other
> versions of the 8 series i have tested so far.
> 
> 
> Am 25.04.2008 um 23:14 schrieb Ben Faga:
> 
> > Thanks for the letting us know about this.  It seems like a
> > reasonable
> > suggestion since double quotes are a valid way to refer to column
> > names.
> > 
> > I'll probably make the change to the svn repository later tonight.
> > 
> > I'm curious though, why are quotes needed for uppercase columns?  Is
> > there some sort of reserved meaning for uc names?
> > 
> > Ben
> > 
> > 
> > On Fri, 2008-04-25 at 10:32 +0200, Daniel Böhringer wrote:
> > > Dear list,
> > > 
> > > in order to support uppercase foreign key target-columns
> > > 
> > > line 608 has to be changed from
> > > 
> > > 
> > > parens_word_list : '(' WORD(s /,/) ')'
> > > to
> > > 
> > > 
> > > parens_word_list : '(' name_with_opt_quotes(s /,/) ')'
> > > 
> > > 
> > > thanks and kind regards,
> > > 
> > > daniel boehringer
> > > 
> > > 
> > > -------------------------------------------------------------------------
> > > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> > > Don't miss this year's exciting event. There's still time to save
> > > $100. 
> > > Use priority code J8TL2D2. 
> > > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> > 
> 
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-- 
sqlfairy-developers mailing list
sqlfairy-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers

Reply via email to