On 27/11/2007, Oleg Broytmann <[EMAIL PROTECTED]> wrote: > On Tue, Nov 27, 2007 at 08:17:55PM +0100, Markus Gritsch wrote: > > use_unicode specifies only if MySQLdb should *return* string values as > > unicode or as strings. Queries can be issued using unicode or string > > regardless of this parameter. > > This means SQLObject doesn't need to encode queries at all. Not only we > can remove that try/except, but remove the call to unicode() completely. > Well, what do you think about the attached patch? It removes > need_unicode and the call unicode(). It also ignores sqlobject_encoding > because self.encoding is no longer needed. Probably SQLObject should issue > a warning on sqlobject_encoding instead of silently ignore it. > Please test the patch.
The patch works great! If sqlobject_encoding is present, it is not silently ignored, but an Exception is raised: 'got an unexpected keyword', which is ok. Thank you very much. Markus ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ sqlobject-discuss mailing list sqlobject-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
