[
https://issues.apache.org/jira/browse/SQOOP-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082001#comment-13082001
]
[email protected] commented on SQOOP-305:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1439/#review1369
-----------------------------------------------------------
Thanks for the patch, overall it looks very good. I have a few comments below.
Also, it will be great if you could run checkstyle and findbus and address any
generated warnings.
/src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java
<https://reviews.apache.org/r/1439/#comment3143>
I think this should result in an exception as it is indicative of data
corruption.
/src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java
<https://reviews.apache.org/r/1439/#comment3146>
Any reason why this is not refactored inplace in the base class?
/src/java/com/cloudera/sqoop/orm/ClassWriter.java
<https://reviews.apache.org/r/1439/#comment3145>
I understand this is a convenient reuse of logic. However, it will be
preferable if the corresponding method on ConnManager class can be overloaded
instead. Your thoughts on doing it there?
- Arvind
On 2011-08-09 21:58:00, Tom White wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1439/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-09 21:58:00)
bq.
bq.
bq. Review request for Sqoop.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See https://issues.apache.org/jira/browse/SQOOP-305
bq.
bq.
bq. This addresses bug SQOOP-305.
bq. https://issues.apache.org/jira/browse/SQOOP-305
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java
PRE-CREATION
bq. /src/java/com/cloudera/sqoop/mapreduce/AvroImportMapper.java 1154359
bq. /src/java/com/cloudera/sqoop/mapreduce/AvroInputFormat.java PRE-CREATION
bq. /src/java/com/cloudera/sqoop/mapreduce/AvroRecordReader.java
PRE-CREATION
bq. /src/java/com/cloudera/sqoop/mapreduce/ExportJobBase.java 1154359
bq. /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1154359
bq. /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1154359
bq. /src/test/com/cloudera/sqoop/TestAvroExport.java PRE-CREATION
bq. /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java
PRE-CREATION
bq. /src/test/com/cloudera/sqoop/TestExport.java 1154359
bq. /src/test/com/cloudera/sqoop/TestExportUpdate.java 1154359
bq. /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1154359
bq. /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1154359
bq.
bq. Diff: https://reviews.apache.org/r/1439/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Tom
bq.
bq.
> Support export from Avro Data Files
> -----------------------------------
>
> Key: SQOOP-305
> URL: https://issues.apache.org/jira/browse/SQOOP-305
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 1.4.0
>
> Attachments: SQOOP-305.patch, SQOOP-305.patch
>
>
> It should be possible to export data in Avro Data Files to DB tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
