> On 2011-09-16 21:00:37, Arvind Prabhakar wrote: > > Thanks for taking this up Joey. Considering the various platforms that > > Sqoop is used on, it is likely that this change may cause some backward > > compatibility issues for some. In order to avoid that, I would suggest > > conditionally using the mkfifo based on environment setting or command line > > option. > > > > Your thoughts?
Any comments on the latest version? - Joey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1938/#review1944 ----------------------------------------------------------- On 2011-09-19 01:06:45, Joey Echeverria wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1938/ > ----------------------------------------------------------- > > (Updated 2011-09-19 01:06:45) > > > Review request for Sqoop. > > > Summary > ------- > > Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility > with Mac OS X. > > > This addresses bug SQOOP-339. > https://issues.apache.org/jira/browse/SQOOP-339 > > > Diffs > ----- > > src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb > > Diff: https://reviews.apache.org/r/1938/diff > > > Testing > ------- > > No new tests as the functionality is covered by an existing unit test. I ran > the existing unit test and it worked. I don't have a Mac to test on right > now, so it might be good to run the unit tests on one before commit. > > > Thanks, > > Joey > >
