-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1938/
-----------------------------------------------------------

(Updated 2011-09-19 01:06:45.395494)


Review request for Sqoop.


Changes
-------

Here's a version that looks for mkfifo and falls back to mknod if it's not 
available. This should gracefully handle any os without introducing a new 
configuration parameter.


Summary
-------

Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility 
with Mac OS X.


This addresses bug SQOOP-339.
    https://issues.apache.org/jira/browse/SQOOP-339


Diffs (updated)
-----

  src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb 

Diff: https://reviews.apache.org/r/1938/diff


Testing
-------

No new tests as the functionality is covered by an existing unit test. I ran 
the existing unit test and it worked. I don't have a Mac to test on right now, 
so it might be good to run the unit tests on one before commit.


Thanks,

Joey

Reply via email to