----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1983/#review1989 -----------------------------------------------------------
Thanks for the patch! One thing though. Those catalog queries (except for the current timestamp one) are specific to DB2 LUW and thus they may not work for other platforms (like zOS) of DB2. /src/java/com/cloudera/sqoop/manager/Db2Manager.java <https://reviews.apache.org/r/1983/#comment4481> So you may want to consider not to inherit from CatalogQueryManager. For listDatabases(), you could use DatabaseMetaData.getSchemas() for cross-platform support. For listTables(), getColumnNames(), and getPrimaryKey(), parent methods in SqlManager would be supported across platforms since they use generic JDBC metadata APIs. - Bilung On 2011-09-20 17:30:46, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1983/ > ----------------------------------------------------------- > > (Updated 2011-09-20 17:30:46) > > > Review request for Sqoop and Bilung Lee. > > > Summary > ------- > > Added Db2Manager implementation along with a simple import test that is > currently categorized as manual test. > > > This addresses bug SQOOP-329. > https://issues.apache.org/jira/browse/SQOOP-329 > > > Diffs > ----- > > /COMPILING.txt 1172789 > /src/java/com/cloudera/sqoop/manager/Db2Manager.java PRE-CREATION > /src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java 1172789 > /src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/1983/diff > > > Testing > ------- > > Ran all the unit, thirdparty, and manual tests. Checkstyle/findbugs did not > introduce new warnings. > > > Thanks, > > Arvind > >
