----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1983/#review1990 -----------------------------------------------------------
Ship it! +1 - Bilung On 2011-09-21 02:08:31, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1983/ > ----------------------------------------------------------- > > (Updated 2011-09-21 02:08:31) > > > Review request for Sqoop and Bilung Lee. > > > Summary > ------- > > Added Db2Manager implementation along with a simple import test that is > currently categorized as manual test. > > > This addresses bug SQOOP-329. > https://issues.apache.org/jira/browse/SQOOP-329 > > > Diffs > ----- > > /COMPILING.txt 1172789 > /src/java/com/cloudera/sqoop/manager/Db2Manager.java PRE-CREATION > /src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java 1172789 > /src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/1983/diff > > > Testing > ------- > > Ran all the unit, thirdparty, and manual tests. Checkstyle/findbugs did not > introduce new warnings. > > > Thanks, > > Arvind > >
