-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1938/
-----------------------------------------------------------
(Updated 2011-09-21 23:42:24.872739)
Review request for Sqoop.
Changes
-------
I added a try/catch around the call to mknod. If an exception is thrown, it
will fall back to mkfifo. If mkfifo throws, then that's thrown to the caller. I
also ran the 4 tests that Arvind did and all four passed.
Summary
-------
Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility
with Mac OS X.
This addresses bug SQOOP-339.
https://issues.apache.org/jira/browse/SQOOP-339
Diffs (updated)
-----
src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb
Diff: https://reviews.apache.org/r/1938/diff
Testing
-------
No new tests as the functionality is covered by an existing unit test. I ran
the existing unit test and it worked. I don't have a Mac to test on right now,
so it might be good to run the unit tests on one before commit.
Thanks,
Joey
