----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2115/#review2200 -----------------------------------------------------------
Look good overall. One suggestion below (same but at different places). /src/java/com/cloudera/sqoop/manager/ConnManager.java <https://reviews.apache.org/r/2115/#comment5131> You may want to consider to make it an error if the length is 0. /src/java/com/cloudera/sqoop/manager/OracleManager.java <https://reviews.apache.org/r/2115/#comment5132> Same here. /src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java <https://reviews.apache.org/r/2115/#comment5133> Same here. /src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java <https://reviews.apache.org/r/2115/#comment5134> Same here. /src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java <https://reviews.apache.org/r/2115/#comment5135> Same here. - Bilung On 2011-09-29 18:44:45, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2115/ > ----------------------------------------------------------- > > (Updated 2011-09-29 18:44:45) > > > Review request for Sqoop and Bilung Lee. > > > Summary > ------- > > Implemented the requested feature, added a few test cases and removed some > existing checkstyle warnings from the code. > > > This addresses bug SQOOP-313. > https://issues.apache.org/jira/browse/SQOOP-313 > > > Diffs > ----- > > /src/docs/man/sqoop-export.txt 1177090 > /src/docs/user/export.txt 1177090 > /src/java/com/cloudera/sqoop/manager/ConnManager.java 1177090 > /src/java/com/cloudera/sqoop/manager/OracleManager.java 1177090 > /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 1177090 > /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1177090 > /src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java 1177090 > /src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java 1177090 > /src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java > 1177090 > /src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java 1177090 > /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1177090 > /src/test/com/cloudera/sqoop/TestExportUpdate.java 1177090 > /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1177090 > /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1177090 > > Diff: https://reviews.apache.org/r/2115/diff > > > Testing > ------- > > Ran unit and third-party tests. Also added a few new tests to exercise this > functionality. > > > Thanks, > > Arvind > >
