-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2115/#review2204
-----------------------------------------------------------

Ship it!


Thanks for the update!

- Bilung


On 2011-09-30 01:49:27, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2115/
> -----------------------------------------------------------
> 
> (Updated 2011-09-30 01:49:27)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Implemented the requested feature, added a few test cases and removed some 
> existing checkstyle warnings from the code.
> 
> 
> This addresses bug SQOOP-313.
>     https://issues.apache.org/jira/browse/SQOOP-313
> 
> 
> Diffs
> -----
> 
>   /src/docs/man/sqoop-export.txt 1177090 
>   /src/docs/user/export.txt 1177090 
>   /src/java/com/cloudera/sqoop/manager/ConnManager.java 1177090 
>   /src/java/com/cloudera/sqoop/manager/OracleManager.java 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java 
> 1177090 
>   /src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java 1177090 
>   /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1177090 
>   /src/test/com/cloudera/sqoop/TestExportUpdate.java 1177090 
>   /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1177090 
>   /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1177090 
> 
> Diff: https://reviews.apache.org/r/2115/diff
> 
> 
> Testing
> -------
> 
> Ran unit and third-party tests. Also added a few new tests to exercise this 
> functionality.
> 
> 
> Thanks,
> 
> Arvind
> 
>

Reply via email to