[
https://issues.apache.org/jira/browse/SQOOP-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117809#comment-13117809
]
[email protected] commented on SQOOP-313:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2115/#review2200
-----------------------------------------------------------
Look good overall. One suggestion below (same but at different places).
/src/java/com/cloudera/sqoop/manager/ConnManager.java
<https://reviews.apache.org/r/2115/#comment5131>
You may want to consider to make it an error if the length is 0.
/src/java/com/cloudera/sqoop/manager/OracleManager.java
<https://reviews.apache.org/r/2115/#comment5132>
Same here.
/src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java
<https://reviews.apache.org/r/2115/#comment5133>
Same here.
/src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java
<https://reviews.apache.org/r/2115/#comment5134>
Same here.
/src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java
<https://reviews.apache.org/r/2115/#comment5135>
Same here.
- Bilung
On 2011-09-29 18:44:45, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2115/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 18:44:45)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Implemented the requested feature, added a few test cases and removed some
existing checkstyle warnings from the code.
bq.
bq.
bq. This addresses bug SQOOP-313.
bq. https://issues.apache.org/jira/browse/SQOOP-313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/docs/man/sqoop-export.txt 1177090
bq. /src/docs/user/export.txt 1177090
bq. /src/java/com/cloudera/sqoop/manager/ConnManager.java 1177090
bq. /src/java/com/cloudera/sqoop/manager/OracleManager.java 1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java 1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java 1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java
1177090
bq. /src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java 1177090
bq. /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1177090
bq. /src/test/com/cloudera/sqoop/TestExportUpdate.java 1177090
bq. /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1177090
bq. /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1177090
bq.
bq. Diff: https://reviews.apache.org/r/2115/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit and third-party tests. Also added a few new tests to exercise
this functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Multiple column names to be included in --update-key argument with SQOOP
> export (update)
> ----------------------------------------------------------------------------------------
>
> Key: SQOOP-313
> URL: https://issues.apache.org/jira/browse/SQOOP-313
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Bejoy KS
> Assignee: Arvind Prabhakar
> Attachments: SQOOP-313.patch
>
>
> Currently the --update-key argument in SQOOP export (Updates) supports only
> one column name. But in most real time scenarios the target db table would
> have composite primary key hence in the SQL generated by SQOOP we may have to
> include more than one condition separated by AND in the WHERE clauses, ie the
> db UPDATE query generated should be like
> UPDATE .... SET ... WHERE PKColumn1 = '<value>' AND PKColumn2= '<value>' AND
> ...
> For this we need to modify --update-key argument to accomodate more that one
> column name which is separated using some separator like comma.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
