[ 
https://issues.apache.org/jira/browse/SQOOP-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117822#comment-13117822
 ] 

[email protected] commented on SQOOP-313:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2115/
-----------------------------------------------------------

(Updated 2011-09-30 01:49:27.339886)


Review request for Sqoop and Bilung Lee.


Changes
-------

Thanks for the review Bilung. I have updated the patch based on your feedback. 
Also ran full unit and third-party tests to verify.


Summary
-------

Implemented the requested feature, added a few test cases and removed some 
existing checkstyle warnings from the code.


This addresses bug SQOOP-313.
    https://issues.apache.org/jira/browse/SQOOP-313


Diffs (updated)
-----

  /src/docs/man/sqoop-export.txt 1177090 
  /src/docs/user/export.txt 1177090 
  /src/java/com/cloudera/sqoop/manager/ConnManager.java 1177090 
  /src/java/com/cloudera/sqoop/manager/OracleManager.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java 1177090 
  /src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java 1177090 
  /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1177090 
  /src/test/com/cloudera/sqoop/TestExportUpdate.java 1177090 
  /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1177090 
  /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1177090 

Diff: https://reviews.apache.org/r/2115/diff


Testing
-------

Ran unit and third-party tests. Also added a few new tests to exercise this 
functionality.


Thanks,

Arvind


                
> Multiple column names to be included in --update-key argument with SQOOP 
> export (update)
> ----------------------------------------------------------------------------------------
>
>                 Key: SQOOP-313
>                 URL: https://issues.apache.org/jira/browse/SQOOP-313
>             Project: Sqoop
>          Issue Type: New Feature
>            Reporter: Bejoy KS
>            Assignee: Arvind Prabhakar
>         Attachments: SQOOP-313-1.patch, SQOOP-313.patch
>
>
> Currently the --update-key argument in SQOOP export (Updates) supports only 
> one column name. But in most real time scenarios the target db table would 
> have composite primary key hence in the SQL generated by SQOOP we may have to 
> include more than one condition separated by AND in the WHERE clauses, ie the 
> db UPDATE query generated should be like 
> UPDATE ....  SET ... WHERE PKColumn1 = '<value>' AND PKColumn2= '<value>' AND 
> ...
> For this we need to modify --update-key argument to accomodate  more that one 
> column name  which is separated using some separator like comma.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to