[
https://issues.apache.org/jira/browse/SQOOP-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152436#comment-13152436
]
[email protected] commented on SQOOP-393:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/#review3334
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Jarcec. Please attach the patch to the JIRA for commit.
- Arvind
On 2011-11-17 18:47:44, Jarek Jarcec wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2874/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-17 18:47:44)
bq.
bq.
bq. Review request for Sqoop and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've moved the functionality like we did with other classes.
bq.
bq.
bq. This addresses bug SQOOP-393.
bq. https://issues.apache.org/jira/browse/SQOOP-393
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
bq. /src/java/org/apache/sqoop/SqoopOptions.java 1201319
bq.
bq. Diff: https://reviews.apache.org/r/2874/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I've passed basic tests.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Class SqoopOptions was not properly moved
> -----------------------------------------
>
> Key: SQOOP-393
> URL: https://issues.apache.org/jira/browse/SQOOP-393
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.4.0-incubating
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
>
> Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and
> org.apache.sqoop) have the same implementation (looks like file copy with
> just few changes). We did not moved the functionality to org.apache.sqoop and
> set up inheritance to com.cloudera.sqoop namespace as we did with other
> classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
