gordonb3 wrote: 
> Interesting.
> 
> Since the number of changes were limited I did some tracing and found
> the offending change:
> 
> > 
Code:
--------------------
  >   > 
  > diff --git a/Slim/Player/Squeezebox.pm b/Slim/Player/Squeezebox.pm
  > index e3411fe0e94..786c5a8600e 100644
  > --- a/Slim/Player/Squeezebox.pm
  > +++ b/Slim/Player/Squeezebox.pm
  > @@ -705,12 +705,8 @@ sub stream_s {
  > 
  > # container type and bitstream format: '1' (adif), '2' (adts), '3' (latm 
within loas), 
  > # '4' (rawpkts), '5' (mp4ff), '6' (latm within rawpkts)
  > -#
  > -# This is a hack that assumes:
  > -# (1) If the original content-type of the track is MP4 or SLS then we are 
streaming an MP4 file (without any transcoding);
  > -# (2) All other AAC streams will be adts.
  > -
  > -$pcmsamplesize   = Slim::Music::Info::contentType($track) =~ 
/^(?:mp4|sls)$/ ? '5' : '2';
  > +
  > +$pcmsamplesize   =  $controller->song->wantFormat ne 'aac' ? '5' : '2';
  > $pcmsamplerate   = '?';
  > $pcmendian       = '?';
  > $pcmchannels     = '?';
  > 
  > 
--------------------
> > 
> 
> Thanks for finding the correct method to fix this.

This is part of what I had to do to allow players that support aac to
play mp4 streams but also to allow LMS to transcode when they don’t.
It’s true that LMS does not benefit from mp4 to aac unwrapping when
transcoding is disabled. Candidly, when I was writing that I was of the
opinion that the notranscoding option should simply be removed



LMS 8.2 on Odroid-C4 - *SqueezeAMP!*, 5xRadio, 5xBoom, 2xDuet, 1xTouch,
1xSB3. Sonos PLAY:3, PLAY:5, Marantz NR1603, Foobar2000, ShairPortW,
2xChromecast Audio, Chromecast v1 and v2, Squeezelite on Pi,  Yamaha
WX-010, AppleTV 4, Airport Express, GGMM E5, RivaArena 1 & 3
------------------------------------------------------------------------
philippe_44's Profile: http://forums.slimdevices.com/member.php?userid=17261
View this thread: http://forums.slimdevices.com/showthread.php?t=117085

_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter

Reply via email to