On 1/04/2016 6:22 p.m., Nathan Hoad wrote: > I've attached two patches - they're functionally identical, one uses > SBuf and the other using MemBuf. The patch achieves the following: > > - Moves all of Http::Stream's uses of StoreIOBuffer objects into a > method, as done previously. > - Adjusts the read_ahead_gap default to 64 KB as Amos suggested. > - Replaces Http::Stream::reqbuf with a SBuf/MemBuf. > - Make the buffer member private. > - Adds a new configuration option for the size of the buffer, with a > default of 64 KB, in the spirit of the original patch. > > I'm not convinced that http_stream_buffer_size is the best name, but I
HTTP/2 has a concept of stream "window" (aka I/O buffering) which has space that shrinks and grows as data arrives and leaves. We could call this http_stream_window_max. > can't think of anything better. The patches are also abusing > MemBuf/SBuf - they're being used purely to allow configuration of the > buffer size, they're not being used as they normally are, or growing > dynamically. That would involve quite a few more changes, I think. > Nod. MemBuf that is actually one of the existing uses elsewhere (ew). SBuf its abnormal - which is why I said this was long term and a lot of work. I'm not expecting you to do that. Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
