On 04/13/2016 08:22 AM, Amos Jeffries wrote: > Alex, have you had time to review this updated patch?
Not yet. > For my part I am wondering if the class StoreIOBuffer needs to have move > constructor/assignment added now that getClientStreamBuffer() is > returning a temporary variable by-value. Sorry, I do not follow your logic: 1. AFAIK, move methods are _optimizations_ so any "X needs move constructor/assignment" statement does not compute for me in a seemingly non-optimization context like "getClientStreamBuffer() is returning a temporary variable by-value". 2. AFAIK, StoreIOBuffer already has move constructor and assignment operator (provided by the compiler). Please clarify what problems adding [explicit] move methods would solve. Thank you, Alex. _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
