Hi everyone,

there is a compilation error on a squid 2.6.STABLE12 with the client ICAP.
In http.c at line 1144 i have:
                httpState->entry = storeCreateEntry("fake", fake_flags, 
fake_method);
but
httpState->entry = storeCreateEntry("fake", "fake", fake_flags, fake_method);
is ok for the compilation.

In icap_reqmod.c at line 270 I have :
                
                method = urlParseMethod(mstr, strlen(mstr));
but urlParseMethod has change :
                method = urlParseMethod(mstr);

In the same file at line 690 I have:
        RequestMethods[icap->request->method].str,
but
        RequestMethodStr[icap->request->method],
seems to be the new call requiered.

I'm not really sure with these modifications ( I've made a very quick test in reqmod and squid crashes with a null pointer in a call to xstrdup... I'm not really sure about this. ).

Ghislain

Reply via email to