On Sun, 2008-04-13 at 00:10 +1200, Amos Jeffries wrote: > Testing: > > - You have moved the ICAP testHeaders to the new ICAP Makefile.am > but appear to have left it out of the eCAP one.
Please ignore the eCAP directory. It was only committed as a placeholder in this round to show how it will be handled in upper Makefiles and configure.in. > - You also have not added an entry for auto-testing src/adaptation/*.h > (any other new folders I've missed seeing right now?) That should be done, yes. Or I might wait until the layout cleanup that might auto-enable such tests in every directory with a compliant Makefile.am via inclusion of common.am. > Documentation: > > - Could you please add all the new module-wrapping macros to squid3.dox > so the new code gets documentation generated. > (just search the file for ICAP_CLIENT to see what to do) Have not looked at it yet. Will do. > - Could you please update the release-notes-3.1.sgml file, including > the new configure options and squid.conf options. Will do, but maybe when all the options/changes are known. > The only code niggle I have found so far is the inconsistent case naming > of libeCAP.la vs libicap.la and others. Please ignore the eCAP directory. It will be renamed to ecap to match the agreed convention for directory names. Thank you, Alex.
