Hi Alex,
Sorry I did not get time to properly audit your patch before it went
in. Thankfully my comments are easily fixed as followup.
Testing:
- You have moved the ICAP testHeaders to the new ICAP Makefile.am
but appear to have left it out of the eCAP one.
It should be there too, even if its commented out saying there
are no .h to test (yet)
- You also have not added an entry for auto-testing src/adaptation/*.h
(any other new folders I've missed seeing right now?)
FYI:
Every source directory needs to have a testHeaders entry somewhere.
It's not recursive. Any given directory should have its testing done in
the nearest Makefile.am (as viewed up the FS tree from the child
directory up to / root).
Those directories with no .h should still have an entry, its just
commented out and labeled clearly in the Makefile.am as having no .h. If
thats ever false we need to uncomment the entry.
Documentation:
- Could you please add all the new module-wrapping macros to squid3.dox
so the new code gets documentation generated.
(just search the file for ICAP_CLIENT to see what to do)
- Could you please update the release-notes-3.1.sgml file, including
the new configure options and squid.conf options.
The only code niggle I have found so far is the inconsistent case naming
of libeCAP.la vs libicap.la and others.
Amos
--
Please use Squid 2.6.STABLE19 or 3.0.STABLE4
