Alex Rousskov wrote:
On Sun, 2008-12-21 at 20:10 +0000, [email protected] wrote:

The following page has been changed by AdrianChadd:
http://wiki.squid-cache.org/Features/SourceLayout?action=diff&rev1=38&rev2=39

------------------------------------------------------------------------------
  ||  || '''Group''' || '''Definition''' || '''Files''' ||
  ||  || ''acl/'' || Access Controls || ACL* external_acl.* ||
  || {2} || ''auth/'' || Authentication support || auth/* ||
+ || {3} || ''core/'' || Core stuff which hasn't been further broken apart || ? 
||
  ||  || ''comm/'' || I/O subsystem || Comm*, comm*  ||
  ||  || ''store/'' || generic (fs-agnostic) disk and memory cache support? || 
Store* store* ||
  ||  || ''http/'' || HTTP primitives shared by client, server, and ICAP sides 
|| Http* ||


There are two problems with this addition:

1) The directory name should not be "core". That name is treated
specially in some environments. I have tried that directory name in the
past and ran into problems with makefiles, archival tools, etc. I ended
up using "base" in other projects, but there may be better alternatives.

+2 on using "base" for now. Though I'm actually expecting a better name can be found.


2) The definition may imply that this directory will accumulate stuff
that has not been broken apart _yet_. That implication would be wrong.
The base directory should only contain code that we do not expect to
isolate into a more specific directory. Very few and very basic things
should go there.

Stuff that we have not isolated yet should remain where it is, IMO.

+3.

Amos
--
Please be using
  Current Stable Squid 2.7.STABLE5 or 3.0.STABLE11
  Current Beta Squid 3.1.0.3

Reply via email to