On Mon, 31 May 2010 23:47:40 +0100, "Markus Moeller" <[email protected]> wrote: > "Amos Jeffries" <[email protected]> wrote in message > news:[email protected]... >> On Sun, 30 May 2010 16:15:14 +0100, "Markus Moeller" >> <[email protected]> wrote: >>> Hi, >>> >>> I have converted my helper to kerberos_ldap_group ( not sure if that >> is >>> the best name) and created a patch for inclusion into the head revision. >> >>> Please review and let me know any feedback. >>> >>> >>> Thank you >>> Markus >> >> Hi Markus,
Okay, some more checks. configure.in: * According to the GNU docs pre-processor only directives are to be avoided when possible since they do not guarantee a working binary. Could you use AC_COMPILE_IFELSE instead of the AC_EGREP_CPP and AC_EGREP_HEADER ? kerberos_ldap_group/README: * Would you mind converting the README file to a man.8 page? There is a template at th bottom of http://wiki.squid-cache.org/ProgrammingGuide/ManualDocumentation Amos
