Hi Amos,
Thank you for the review. I will try to address your points over the
next weeks.
Markus
"Amos Jeffries" <[email protected]> wrote in message
news:[email protected]...
Markus Moeller wrote:
Hi Amos,
How does your time look like now ?
Regards
Markus
Looks passable. I have not had time for a detailed view of the logics.
I'll commit this tomorrow with a name tweak, the naming scheme has been
through the external acl helpers too now. I'll just tack ext_ on the front
and _acl on the back of the existing binary name and update the docs to
match.
One thing that worries me still is the RUN_IFELSE autoconf macros still
being added to configure.in. I'm sure there is a macro that checked for
defined values of things inside headers without running stuff. If you can
try and find that it would be great not to have to run anything on build.
The following is optional...
As always the 3.HEAD code has advanced a bit. Fallout from the helper
upgrades has been the beginning of a common code API.
These are the to consider updating the helper with in the current 3.HEAD:
* helpers/defines.h provides a few macros that may be useful:
SEND_ERR(msg) - takes a string or buffer containing the error message
to be available to user and admin. May be used in cache.log and/or user
displayed error pages.
SEND_OK(params) - takes a string of whitespace delimited key=value
pairs. Whatever the helper hook accepts, which varies with squid release.
* A global variable "debug_enabled" is available to be set to 1 on
receiving -d (debug) parameters. It controls whether the function
debug("fmt",x,y,...) produces any output. debug(...) is equivalent to:
if(debug_enabled) fprintf(stderr,...)
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.5
