On 19/09/10 05:54, Andrew Beverley wrote:
On Sun, 2010-09-19 at 04:24 +1200, Amos Jeffries wrote:
On 19/09/10 00:47, Andrew Beverley wrote:
On Sat, 2010-09-18 at 20:34 +1200, Amos Jeffries wrote:
On 18/09/10 09:18, Andrew Beverley wrote:
Hi,
Please find attached updated netfilter mark (and QOS tidy up) patch.
It takes into account all the recent feedback, but leaves the
tcp_outgoing_* and clientside_* configuration functions in cache_cf.cc
as discussed on the mailing list.
It remains not fully tested, but is provided for any further comments.
Thanks,
Andy
configure.in:
AC_SEARCH_LIBS for the library still needs to be performed. Its
happened before that newbies see the missing-header text and copy *only*
the header file onto their box.
Just dropping it out of the else section next to the headers check
should be enough.
I've moved it next to the headers check. I have also removed the error
message that was generated if they don't exist. However, this means that
if somebody explicitly sets --with-netfilter-conntrack and the libraries
don't exist, then it will silently fail. Is this the behaviour we want?
Hmm, we at least want to MSG_NOTICE for both cases, with preferrably a
hard error if its explicitly stated.
There'll be the default AC_SEARCH_LIBS notice in any case, and then it
will also be shown later assuming --enable-zph-qos is set. I've just
realised though that by default the QOS functions are disabled. I
thought the new concept was that everything was enabled by default?
Should I change the default to enabled for --enable-zph-qos?
Yes please.
Unless someone else has anything more I think thats it now.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.8
Beta testers wanted for 3.2.0.2
