On Wed, 2010-10-06 at 10:17 +0200, Kinkie wrote: > > Hmm, we at least want to MSG_NOTICE for both cases, with preferrably a hard > > error if its explicitly stated. > > > > This is where the yes/no/auto comes in handy to switch the type of fail > > message. > > Hi guys, > handling of the --with-netfilter-conntrack option seems broken to me. > e.g.: > with_netfilter_conntrack=$withval > Why do that? it's already done by configure automagics..
Yes, good point. > Also, it doesn't properly handle the yes/no/auto tristate, and it > actually defaults to "yes" rather than "auto" which is not in line > with the documentation text. True, but it gets set back to "no" if the libraries are subsequently not found. Not a problem though if Amos has changed it to a better way of doing it. Thanks for the help from everyone implementing the patch. As you probably realised I am something of an amateur coder, but I appreciate all the patience and guidance. The Squid3VCS wiki was very useful; the only minor point is that a note in there to stipulate a commit message before submitting a patch might be useful. Thanks, Andy
