On 11/18/2013 10:57 AM, Tsantilas Christos wrote: > On 11/15/2013 05:11 PM, Amos Jeffries wrote: >> in src/auth/ntlm/UserRequest.cc: >> >> * the YR and KK are lookups codes, not part of the credentials. They >> must be first on the helper query line and not manipulable by the admin. >> - same problem in Negotiate as well. > > > If we remove the lookupcodes from credentials then we have to implement > one more formating code which will print the type of cretendials. > > I believe that it is better to keep YR and KK as part or cretendials as > prefixes which describe type of cretendials.
I agree, but this point will probably become moot if we delete all %credentials code. If I understand Amos request correctly, the patch should only append user-configurable fields (no %credentials there!) to the internally generated (by the old code!) [type+]credentials buffer. HTH, Alex.