On 11/19/2013 07:46 PM, Amos Jeffries wrote: > On 20/11/2013 12:49 p.m., Alex Rousskov wrote: >> On 11/19/2013 04:01 PM, Amos Jeffries wrote: > <snip> > >>> If you want to omit it from this patch and do it as a second one that >>> would be okay. >> >> I do not like the idea of increasing the amount of work further by >> splitting this feature into two. I think your choices are: >> >> 1) Allow %credentials to be used internally in the key_extras patch. >> This is less work for Christos (because the code is already written) and >> adds a potentially useful feature to Squid. > > This one I think. > If you mean leaving the %credentials in as a log option
Yes, as a new logformat code. > which may be used inside the key_extras format code. Yes, but the admin will not be expected to add it to key_extras. Squid will form the helper request by automatically concatenating %credentials and configured key_extras. > If you mean using it as the way to build the existing prefix portion of > the submitted helper line, no. For the reason that the log line > processing has quoting and encoding logics that will need to be avoided > - lets reduce the work policing that. Since %credentials will be added by Squid itself, the macro will not have any modifiers, and we will not have to deal with custom quoting or encoding issues. Current patch: take admin-provided request_format and expand %macros in its value to form a helper request Revised patch: take admin-provided key_suffix, prepend "%credentials ", and expand %macros in the concatenated value to form a helper request Thank you, Alex.
