On 12/03/2013 12:49 AM, Francesco Chemolli wrote: > As this patch is a cherrypick of lp:~squid/squid/stringng, I'm not > extracting the Makefile.am changes as it's too time-consuming. These > changes are present in the branch Makefile.am and will be included at > the final merge time, but are not really significant for review, are > they?
They are not, but a reviewer sometimes actually tests the patch. I know it sounds crazy, but it does happen once in a while. You have actually warned about the missing Makefile changes in your original submission, but I forgot that caveat after so many emails on the thread. Sorry! Since those exact Makefile changes would need to be done to trunk during commit, I am guessing you exclude them now to save time if the patch needs to be adjusted and re-posted for review, right? I am _not_ asking for those changes to be included in the patch. Just trying to understand your motivation or workflow. Not important. Cheers, Alex.
