Hi Amos,
some of these were already mentioned by Alex; I had fixed them but
for some reason the code was reverted to the nonfixed version. I'm
sorry (to the both of you).
Re-fixing them.
> in SBufAlgos.h:
> * for all classes please put the first { of a class on a line of its own.
Ok.
> * inline is not necessary on methods defined within the class body. It
> is for methods declared there and defined elsewhere in the .h or .cci
Ok.
> * SBufStartsWith::sensitive missing trailing _ as per squid coding
> guidelines for private members.
.. and it's inconsistently named with SBufEqual. Fixed. Sorry.
Now named "sensitivity" (parameter) and "sensitivity_" (private member)
> * can SBufAddLength::operator()() be const ? or does that mess with the
> STL requirements?
>
> * please deflate:
> + SBuf::size_type sz;
> + sz =
> and make sz const.
Ok
> in SBufList.cc
> * I think we should avoid having the new code depend on or include the
> old deprecated code. So things like ToSBufList(wordlist *wl) should be
> added to wordlist.cc instead and removed when it is deleted.
Ok.
> in wordlist.h
> * please ensure there is one empty line between a symbol declaration and
> the doxygen comment about next symbol declared.
Ok, done.
Being consolidated (Makefile.am included) and tested as lp:~kinkie/squid/staging
--
/kinkie
