on 1/31/03 6:37 PM, Sam Varshavchik <[EMAIL PROTECTED]> wrote:
> Jesse Guardiani writes:
>
>> IMHO, it would be nice to see these changes incorporated into the distro.
>>
>> Especially if they don't hinder viewing from other browsers.
>>
>> Sam? What do you think?
>
> I'd like to see a sample patch for a sample html template, diffed against
> the current release
[snip]
> Fix one file. Let me kick the tires. If it looks good, send me a patch for
> two or three more HTML templates. And if that looks good too, then do the
> rest.
>
> Oh, and use diff -C or diff -U. A plain diff is just plain worthless.
Ok, here is one file fixed (or so I hope) as Sam requested.
I only made the changes that were essential to fix the problems that were
visible to me. Not all features are enabled in my installation - no
calendaring for example. I don't know if additional problems would have
shown up if additional features were enabled.
I will appreciate feedback from Sam and others willing to apply this change
and try it via their favorite (or most hated) browsers.
You can find the diff -U3 output for my changes to folders.html here:
http://breathhost.net/html/diffs/folders.txt
I have never used a patch, so I hope this is really what is needed.
The diff is against the templates included with sqwebmail-3.5.0.
Giving the above link avoids the problems of line-wrapping that I was having
in my email client. If you have a better idea, or if for some reason you
would prefer an alternative to -U3, just say so. I can set up a cgi to run
the diffs for this whole sequence of upcoming changes easy enough.
In case you just want to see the output here, complete with line-wrapping
problems, it is pasted in below.
-Kurt Bigler
P.S. Diff -U3 output follows. It looks from here like only 1 line was
damaged by a wrap that my email client forced.
--- en-us-orig/folders.html Mon Feb 3 21:45:33 2003
+++ en-us/folders.html Mon Feb 3 21:54:31 2003
@@ -45,7 +45,7 @@
<td align="left" valign="top"
style="line-height: 0">[#@graytopleft.gif, width="11" height="11"
alt="" border="0"@@#]</td>
- <td bgcolor="#cccccc"> </td>
+ <td bgcolor="#cccccc"></td>
<td align="right" valign="top"
style="line-height: 0">[#@graytopright.gif, width="11" height="11"
alt="" border="0"@@#]</td>
@@ -68,7 +68,7 @@
<tr style="line-height: 0">
<td align="left" valign="bottom">[#@graybottomleft.gif, width="11"
height="11" alt="" border="0"@@#]</td>
- <td bgcolor="#cccccc"> </td>
+ <td bgcolor="#cccccc"></td>
<td align="right" valign="bottom">[#@graybottomright.gif, width="11"
height="11" alt="" border="0"@@#]</td>
</tr>
@@ -141,13 +141,14 @@
<tr style="line-height: 0">
<td align="left" valign="top">[#@bluetopleft.gif, width="11"
height="11" alt="" border="0"@@#]</td>
- <td bgcolor="#99ccff" valign="middle" width="100%"> </td>
+ <td bgcolor="#99ccff" valign="middle" width="100%"></td>
<td style="line-height: 0" align="right"
valign="top">[#@bluetopright.gif, width="11" height="11" alt=""
border="0"@@#]</td>
</tr>
<tr>
- <td bgcolor="#99ccff" colspan="3" valign="middle">
+ <td bgcolor="#99ccff"></td>
+ <td bgcolor="#99ccff" valign="middle">
<table border="0" cellpadding="4" width="100%">
<tbody>
<tr>
@@ -248,11 +249,12 @@
</tbody>
</table>
</td>
+ <td bgcolor="#99ccff"></td>
</tr>
<tr style="line-height: 0">
<td align="left" valign="bottom">[#@bluebottomleft.gif, width="11"
height="11" alt="" border="0"@@#]</td>
- <td bgcolor="#99ccff" valign="middle"> </td>
+ <td bgcolor="#99ccff" valign="middle"></td>
<td align="right" valign="bottom">[#@bluebottomright.gif,
width="11"
height="11" alt="" border="0"@@#]</td>
</tr>
