vingarzan left a comment (kamailio/kamailio#4423)
> > Looks like a clean new (optional) feature, so 👍 But do please check my
> > comment below, to ensure it won't crash without the vrf parameter.
>
> It doesn't crash without `vrf`. That was tested.
>
> If you think the optional parameters should not reserve empty pointers. I
> would say I could do that in a different PR.
Nah, that's a huge change :stuck_out_tongue_winking_eye: . I was just biased by
a parallel/similar platform where I used cdp, but str was there a purely binary
blob.
The macro here is wasteful but arguably safer, e.g. if someone uses str->s like
a char* (albeit that's still not a good thing, since str was defined to
compensate for the limitations of char* when storing binary data, so that's
like going back and un-compensating :upside_down_face: ).
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4423#issuecomment-3373092611
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4423/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
