@vingarzan approved this pull request.
Looks like a clean new (optional) feature, so 👍
But do please check my comment below, to ensure it won't crash without the vrf
parameter.
> + shm_str_dup_macro(x->vrf, vrf);
+ if(!x->vrf.s)
+ goto error;
I don't remember how this macro works... because if the there is no parameter,
in my mind it could skip uselessly allocating an empty pointer. So I would've
wrapped this in an `if`, since the `vrf` parameter is optional, right?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4423#pullrequestreview-3306213213
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4423/review/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
