@devopsec commented on this pull request.


> @@ -1290,7 +1290,7 @@ modparam("acc", "cdrs_table", "acc_cdrs")
                                microseconds in time_exten.</para>
                </listitem>
                <listitem>
-                       <para><emphasis>2</emphasis> - save seconds.milliseconds
+                       <para><emphasis>2</emphasis> - save seconds.microseconds

I did consider a different mode but the DB structure would need changed in 
either case so I did not think there was a good way to maintain complete 
backwards compatibility.  
That was my intial thought but as I was thinking this over last night I 
realized we can gracefully handle the check for that change in schema in the 
module initialization.  
@miconda I will reformat this PR and tag as WIP until those changes are in

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4447#discussion_r2490711640
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4447/review/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to