miconda left a comment (kamailio/kamailio#4787)
@zenichev: thanks to putting a lot of effort into this one, the PR is quite
large to review, so I am thinking if a different approach should be discussed
and decided on it, respectively to get this as a new module `permissions2` or a
different name.
Because the module is really used and also security related, I would try to
avoid bringing any instability to it. Then the match has to be done linear
anyhow, therefore I am not sure about relevant benefits of the hash over the
list. Also, in terms of many reloads in very short time, either has to be a
global lock that can block SIP workers or there will be some inconsistency on
gradual reload.
Then, people can decide what module to use and if the new one proves to be
better based on community feedback over a couple of major releases, then the
old one can be archived.
Again, just as a proposal now to have a discussion about this variant...
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4787#issuecomment-4851591265
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4787/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
