Yes, it should be removed. I think it's a left over from a long long time.

-ovidiu

On Fri, Dec 7, 2012 at 6:21 PM, Olle E. Johansson <[email protected]> wrote:
>
> 7 dec 2012 kl. 23:49 skrev Daniel-Constantin Mierla <[email protected]>:
>
>>
>> On 12/7/12 11:08 PM, Olle E. Johansson wrote:
>>> http://kamailio.org/docs/modules/3.3.x/modules/rtpproxy.html#id2531640
>>>
>>> The modparam force_socket that is in the documentation for 3.3.x doesn't 
>>> seem to exist in the source code any longer.
>>>
>>> The source says:
>>> "* 2004-10-10   force_socket option introduced (jiri)"
>>>
>>> That's all I find about it - no comment about it being removed.
>>>
>>> The same comment exists in modules_k/nathelper.c where the function exists. 
>>> Seems like the rtpproxy module has a shared history with nathalper :-)
>> rtpproxy module was split from nathelper (till few versions ago they were 
>> same module, iirc, Ovidiu Sas did it).
>>
>>>
>>> I think it's safe to remove force_socket from the rtpproxy documentation. 
>>> Anyone against?
>>
>> It has to be in the docs of nathelper module, and looking quickly at the 
>> code, it the socket to be used for sending nat ping keepalives.
>
> I parse you that it can safely be removed from the rtpproxy docs then.
>
> Ovidiu? What's your opinion?
>
> /O

_______________________________________________
sr-dev mailing list
[email protected]
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to