Ok ! I keep the patch running. With the patch, the AOR is saved and the outbound routing works.
Thank you. On Mon, Feb 23, 2015 at 4:25 PM, <[email protected]> wrote: > Send sr-dev mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > or, via email, send a message with subject or body 'help' to > [email protected] > > You can reach the person managing the list at > [email protected] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of sr-dev digest..." > > > Today's Topics: > > 1. git:master:91596953: sdpops: safety check when location a= > line not to exceed end of message (Daniel-Constantin Mierla) > 2. Re: [kamailio] registrar - additional features (#91) (lazedo) > 3. aastra outbound support (GG GG) > 4. git:master:b9e5b918: kazoo - fix timeouts (Luis Azedo) > 5. git:4.2:449ba0c0: kazoo - fix timeouts (Luis Azedo) > 6. git:4.2:e24c9ff7: sdpops: safety check when location a= line > not to exceed end of message (Daniel-Constantin Mierla) > 7. Issue after tcpops enhancement for lifetime per connection > (Daniel-Constantin Mierla) > 8. Re: aastra outbound support (Daniel-Constantin Mierla) > 9. Re: [kamailio] registrar - additional features (#91) > (Daniel-Constantin Mierla) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 23 Feb 2015 14:31:19 +0100 > From: Daniel-Constantin Mierla <[email protected]> > To: [email protected] > Subject: [sr-dev] git:master:91596953: sdpops: safety check when > location a= line not to exceed end of message > Message-ID: <[email protected]> > > Module: kamailio > Branch: master > Commit: 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285 > URL: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285 > > Author: Daniel-Constantin Mierla <[email protected]> > Committer: Daniel-Constantin Mierla <[email protected]> > Date: 2015-02-23T14:29:46+01:00 > > sdpops: safety check when location a= line not to exceed end of message > > --- > > Modified: modules/sdpops/sdpops_mod.c > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.diff > Patch: > https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.patch > > --- > > diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c > index 3357bb2..2a4aa6b 100644 > --- a/modules/sdpops/sdpops_mod.c > +++ b/modules/sdpops/sdpops_mod.c > @@ -159,12 +159,17 @@ static int mod_init(void) > int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) > { > char *p; > + char *bend; > + > p = pos; > while(*p!='\n') p--; > aline->s = p + 1; > p = pos; > - while(*p!='\n') p++; > + bend = msg->buf+msg->len; > + while(*p!='\n' && p<bend) p++; > aline->len = p - aline->s + 1; > + if(unlikely(p==bend)) aline->len--; > + > return 0; > } > > > > > > ------------------------------ > > Message: 2 > Date: Mon, 23 Feb 2015 06:14:31 -0800 > From: lazedo <[email protected]> > To: Kamailio Devel List <[email protected]> > Subject: Re: [sr-dev] [kamailio] registrar - additional features (#91) > Message-ID: <kamailio/kamailio/pull/91/[email protected]> > Content-Type: text/plain; charset="utf-8" > > @miconda can you check if this is acceptable ? thanks. > > --- > Reply to this email directly or view it on GitHub: > https://github.com/kamailio/kamailio/pull/91#issuecomment-75547064 > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/a74d9010/attachment-0001.html > > > > ------------------------------ > > Message: 3 > Date: Mon, 23 Feb 2015 15:21:10 -0500 > From: GG GG <[email protected]> > To: [email protected] > Subject: [sr-dev] aastra outbound support > Message-ID: > <CAO= > [email protected]> > Content-Type: text/plain; charset="utf-8" > > Hi ! > > Aastra phone can support outbound (RFC 5626) but they put reg-id=0 in the > SIP REGISTER. > > So the registrar server can't save the AOR and says "invalid reg-id value". > I know Aastra should change that for reg-id=1, I already reported an issue > but no feedback... > > Finally I applied a patch in modules/registrar/save.c: > > -- if(str2int(&_c->reg_id->body, &ci.reg_id)<0 || ci.reg_id==0) > ++ if(str2int(&_c->reg_id->body, &ci.reg_id)<0) > { > LM_ERR("invalid reg-id value\n"); > goto error; > } > > Do you think it's safe to do that ? > > Thank you ! > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/59a5c54b/attachment-0001.html > > > > ------------------------------ > > Message: 4 > Date: Mon, 23 Feb 2015 21:56:18 +0100 > From: Luis Azedo <[email protected]> > To: [email protected] > Subject: [sr-dev] git:master:b9e5b918: kazoo - fix timeouts > Message-ID: <[email protected]> > > Module: kamailio > Branch: master > Commit: b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3 > URL: > https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3 > > Author: Luis Azedo <[email protected]> > Committer: Luis Azedo <[email protected]> > Date: 2015-02-23T20:55:57Z > > kazoo - fix timeouts > > timeout should be ms not sec > set time before state so timeout check doesn't set timeout immediately > separate proc for handling timeouts > > --- > > Modified: modules/kazoo/kazoo.c > Modified: modules/kazoo/kz_amqp.c > Modified: modules/kazoo/kz_amqp.h > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.diff > Patch: > https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.patch > > > > > ------------------------------ > > Message: 5 > Date: Mon, 23 Feb 2015 21:57:18 +0100 > From: Luis Azedo <[email protected]> > To: [email protected] > Subject: [sr-dev] git:4.2:449ba0c0: kazoo - fix timeouts > Message-ID: <[email protected]> > > Module: kamailio > Branch: 4.2 > Commit: 449ba0c0a3a1c79c597452c3411fd823465c9482 > URL: > https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482 > > Author: Luis Azedo <[email protected]> > Committer: Luis Azedo <[email protected]> > Date: 2015-02-23T20:56:53Z > > kazoo - fix timeouts > > timeout should be ms not sec > set time before state so timeout check doesn't set timeout immediately > separate proc for handling timeouts > > (cherry picked from commit b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3) > > --- > > Modified: modules/kazoo/kazoo.c > Modified: modules/kazoo/kz_amqp.c > Modified: modules/kazoo/kz_amqp.h > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.diff > Patch: > https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.patch > > > > > ------------------------------ > > Message: 6 > Date: Mon, 23 Feb 2015 22:03:04 +0100 > From: Daniel-Constantin Mierla <[email protected]> > To: [email protected] > Subject: [sr-dev] git:4.2:e24c9ff7: sdpops: safety check when location > a= line not to exceed end of message > Message-ID: <[email protected]> > > Module: kamailio > Branch: 4.2 > Commit: e24c9ff7038534e07682e8a7bafd903e4303590e > URL: > https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e > > Author: Daniel-Constantin Mierla <[email protected]> > Committer: Daniel-Constantin Mierla <[email protected]> > Date: 2015-02-23T22:02:51+01:00 > > sdpops: safety check when location a= line not to exceed end of message > > (cherry picked from commit 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285) > > --- > > Modified: modules/sdpops/sdpops_mod.c > > --- > > Diff: > https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.diff > Patch: > https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.patch > > --- > > diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c > index 8717343..98c2f84 100644 > --- a/modules/sdpops/sdpops_mod.c > +++ b/modules/sdpops/sdpops_mod.c > @@ -156,12 +156,17 @@ static int mod_init(void) > int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline) > { > char *p; > + char *bend; > + > p = pos; > while(*p!='\n') p--; > aline->s = p + 1; > p = pos; > - while(*p!='\n') p++; > + bend = msg->buf+msg->len; > + while(*p!='\n' && p<bend) p++; > aline->len = p - aline->s + 1; > + if(unlikely(p==bend)) aline->len--; > + > return 0; > } > > > > > > ------------------------------ > > Message: 7 > Date: Mon, 23 Feb 2015 22:16:06 +0100 > From: Daniel-Constantin Mierla <[email protected]> > To: Camille Oudot <[email protected]>, sr-dev > <[email protected]> > Subject: [sr-dev] Issue after tcpops enhancement for lifetime per > connection > Message-ID: <[email protected]> > Content-Type: text/plain; charset=utf-8 > > Hi Camille, > > can you check and see what could have resulted in the issue reported on > users mailing list referred in the next link? > > http://lists.sip-router.org/pipermail/sr-users/2015-February/087101.html > > There were couple of replies with some other details. > > Thanks, > Daniel > > -- > Daniel-Constantin Mierla > http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda > Kamailio World Conference, May 27-29, 2015 > Berlin, Germany - http://www.kamailioworld.com > > > > > ------------------------------ > > Message: 8 > Date: Mon, 23 Feb 2015 22:18:01 +0100 > From: Daniel-Constantin Mierla <[email protected]> > To: "Kamailio (SER) - Development Mailing List" > <[email protected]> > Subject: Re: [sr-dev] aastra outbound support > Message-ID: <[email protected]> > Content-Type: text/plain; charset="windows-1252" > > Hello, > > reg-id=0 is considered like no-outbound is advertised, so probaly no > real outbound routing is done. If that's ok for you, then you can test a > bit for side effects and keep the patch to run for you until aastra is > fixing it. > > Cheers, > Daniel > > On 23/02/15 21:21, GG GG wrote: > > Hi ! > > > > Aastra phone can support outbound (RFC 5626) but they put reg-id=0 in > > the SIP REGISTER. > > > > So the registrar server can't save the AOR and says "invalid reg-id > > value". I know Aastra should change that for reg-id=1, I already > > reported an issue but no feedback... > > > > Finally I applied a patch in modules/registrar/save.c: > > > > -- if(str2int(&_c->reg_id->body, &ci.reg_id)<0 || ci.reg_id==0) > > ++ if(str2int(&_c->reg_id->body, &ci.reg_id)<0) > > { > > LM_ERR("invalid reg-id value\n"); > > goto error; > > } > > > > Do you think it's safe to do that ? > > > > Thank you ! > > > > > > _______________________________________________ > > sr-dev mailing list > > [email protected] > > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > > -- > Daniel-Constantin Mierla > http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda > Kamailio World Conference, May 27-29, 2015 > Berlin, Germany - http://www.kamailioworld.com > > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/c69d9fd2/attachment-0001.html > > > > ------------------------------ > > Message: 9 > Date: Mon, 23 Feb 2015 13:25:20 -0800 > From: Daniel-Constantin Mierla <[email protected]> > To: Kamailio Devel List <[email protected]> > Subject: Re: [sr-dev] [kamailio] registrar - additional features (#91) > Message-ID: <kamailio/kamailio/pull/91/[email protected]> > Content-Type: text/plain; charset="utf-8" > > A bit hard to follow, because now here are patches to patches to patches. > Would be good to have a single patch against the master in kamailio for > review. > > One thing I noticed, that some flags are still a module parameter. > Wouldn't it be more flexible to be part of the function parameter, > different flag values (eventually starting at 8 or 16)? > > --- > Reply to this email directly or view it on GitHub: > https://github.com/kamailio/kamailio/pull/91#issuecomment-75637132 > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/1e571a40/attachment.html > > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > sr-dev mailing list > [email protected] > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev > > > ------------------------------ > > End of sr-dev Digest, Vol 76, Issue 83 > ************************************** >
_______________________________________________ sr-dev mailing list [email protected] http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
