this commit broke presence for us. we use NSQ + presence, after a phone reboots 
and we send a NOTIFY with confirmed state, presence module sends a NOTIFY with 
terminated state.
please revert this commit. see the log and SIP packet below:

```
Nov  3 09:23:52 /usr/local/sbin/kamailio[26288]: INFO: <script>: 
park+6...@troubleshoot.testdomain.com|log|payload 
{"Call-ID":"park+6...@troubleshoot.testdomain.com","Event-Category":"presence","Event-Name":"update","Event-Package":"dialog","Expires":"1","From":"sip:park+6...@troubleshoot.testdomain.com","From-User":"park+6001","From-Realm":"troubleshoot.testdomain.com","To":"sip:testu...@troubleshoot.testdomain.com","To-User":"testuser","To-Realm":"troubleshoot.testdomain.com","State":"confirmed"}
Nov  3 09:23:52 /usr/local/sbin/kamailio[26288]: INFO: <script>: 
park+6...@troubleshoot.testdomain.com|log|received dialog update for 
sip:park+6...@troubleshoot.testdomain.com state confirmed
Nov  3 09:23:53 /usr/local/sbin/kamailio[26284]: INFO: presence 
[notify.c:1634]: send_notify_request(): NOTIFY 
sip:testu...@troubleshoot.testdomain.com via 
sip:testuser@8.1.2.90:25279;transport=tcp on behalf of 
sip:park+6...@troubleshoot.testdomain.com for event dialog : 
46ed33b5954833366fb4eda1d08f6bb7
```

```

                                                            |NOTIFY 
sip:testuser@8.1.2.90:25279;transport=tcp SIP/2.0
            6.7.8.219:5055           8.1.2.90:2527          |Via: SIP/2.0/TCP 
6.7.8.219:5055;branch=z9hG4bKb0d.16516795000000000000000000000000.0
          ----------+---------          ----------+---------|To: 
<sip:testu...@troubleshoot.testdomain.com>;tag=EBF86DE1-F194FBC6
                    |           NOTIFY            |         |From: 
<sip:park+6...@troubleshoot.testdomain.com>;tag=3d72448f6ec66ad72d4fe275f33a4e85-bf81
  09:23:53.007063   | --------------------------> |         |CSeq: 3 NOTIFY
        +0.007681   |           200 OK            |         |Call-ID: 
46ed33b5954833366fb4eda1d08f6bb7
  09:23:53.014744   | <-------------------------- |         |Content-Length: 285
                    |                             |         |User-Agent: 
kamailio (5.0.0-dev7 (x86_64/linux))
                    |                             |         |Max-Forwards: 70
                    |                             |         |Event: dialog
                    |                             |         |Contact: 
<sip:6.7.8.219:5055;transport=tcp>
                    |                             |         
|Subscription-State: active;expires=3491
                    |                             |         |Content-Type: 
application/dialog-info+xml
                    |                             |         |
                    |                             |         |<?xml 
version="1.0"?>
                    |                             |         |<dialog-info 
xmlns="urn:ietf:params:xml:ns:dialog-info" version="3" state="full" 
entity="sip:park+6...@troubleshoot.testdomain.com">
                    |                             |         |  <dialog 
id="615293b33c62dec073e05d9421e9f48b" direction="recipient">
                    |                             |         |    
<state>terminated</state>
                    |                             |         |  </dialog>
                    |                             |         |</dialog-info>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/809#issuecomment-258195982
_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to